Switch to notify prod url #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flypaper0
reviewed
Sep 15, 2023
| @@ -16,7 +16,7 @@ final class NotifyTests: XCTestCase { | |||
|
|
|||
| var walletNotifyClientA: NotifyClient! | |||
|
|
|||
| let gmDappDomain = "dev.gm.walletconnect.com" | |||
| let gmDappDomain = "gm.walletconnect.com" | |||
There was a problem hiding this comment.
not "notify.gm.walletconnect.com" ?
There was a problem hiding this comment.
no, it will be gm.walletconnect.com
|
Can we also remove TODO in ListingViewModel ? |
…letConnectSwiftV2 into switch-to-notify-prod-url
flypaper0
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
waiting for Rust and JS to deploy first
Resolves # (issue)
How Has This Been Tested?
Due Dilligence