[Pair] Present request when reparing #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
radeknovis
approved these changes
Aug 18, 2023
flypaper0
reviewed
Aug 21, 2023
| guard !hasPairing(for: uri.topic) else { | ||
| throw Errors.pairingAlreadyExist(topic: uri.topic) | ||
| guard try !pairingHasPendingRequest(for: uri.topic) else { | ||
| return |
There was a problem hiding this comment.
why it's not throws anymore?
There was a problem hiding this comment.
with throwing error we can easily test this check
There was a problem hiding this comment.
It will throw when try !pairingHasPendingRequest is called instead
flypaper0
reviewed
Aug 21, 2023
| func hasPairing(for topic: String) -> Bool { | ||
| if let pairing = pairingStorage.getPairing(forTopic: topic) { | ||
| return pairing.requestReceived | ||
| func pairingHasPendingRequest(for topic: String) throws -> Bool { |
There was a problem hiding this comment.
do we need unit test for this method?
There was a problem hiding this comment.
Tested in the method testPairOnSameUriPresentsRequest()
|
@flypaper0 @llbartekll the PR is on hold, need to clarify some questions |
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
# Conflicts: # Example/IntegrationTests/Pairing/PairingTests.swift # Example/IntegrationTests/Push/PushTests.swift
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.mp4
Due Dilligence