Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't import library when using another web3.swift library #592

Closed
DarthMike opened this issue Nov 15, 2022 · 3 comments · Fixed by #607
Closed

Can't import library when using another web3.swift library #592

DarthMike opened this issue Nov 15, 2022 · 3 comments · Fixed by #607
Assignees
Labels
bug Something isn't working

Comments

@DarthMike
Copy link

Describe the bug
Setting up a project with the latest version, and another web3 provider library creates conflicts

SDK Version

  • Client: Xcode
  • Version 1.0.4, 1.05

To Reproduce
Steps to reproduce the behavior:

  1. Create new project
  2. Add https://github.com/argentlabs/web3.swift as dependency to project
  3. Add WalletConnectSwiftV2 as dependency to project

Expected behavior
Should be able to add it

Screenshots
Screenshot 2022-11-15 at 12 45 28

error project: Failed to resolve dependencies Dependencies could not be resolved because root depends on 'web3.swift' 1.2.0.
'web3.swift' 1.0.0 is required because 'walletconnectswiftv2' 1.0.5 depends on 'web3.swift' 1.0.0 and root depends on 'walletconnectswiftv2' 1.0.5.

Device (please complete the following information):
N/A

Additional context
Conflict related to imported Web3.swift dependency. Is it really necessary to import such a big library to this SDK?

@DarthMike DarthMike added the bug Something isn't working label Nov 15, 2022
@jatinm11
Copy link

@DarthMike Found any solution for this ?

@DarthMike
Copy link
Author

@jatinm11 I think the best solution would be to not expose the web3 library used as a dependency, given WalletConnect is multichain. But we need the project owners who really understand the implications to decide on this.

@flypaper0 flypaper0 moved this to Todo in Swift SDK Nov 29, 2022
@flypaper0 flypaper0 moved this from Todo to In Progress in Swift SDK Nov 29, 2022
@flypaper0 flypaper0 linked a pull request Nov 29, 2022 that will close this issue
2 tasks
flypaper0 added a commit that referenced this issue Dec 2, 2022
Repository owner moved this from In Progress to Done in Swift SDK Dec 9, 2022
@DarthMike
Copy link
Author

Thanks for the fix @flypaper0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants