Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update session namespaces checks against required namespaces #340

Closed
llbartekll opened this issue Jul 14, 2022 · 0 comments
Closed

Update session namespaces checks against required namespaces #340

llbartekll opened this issue Jul 14, 2022 · 0 comments
Assignees
@sekimondre
Labels
bug Something isn't working
Milestone
v2.0-rc.0

Comments

@llbartekll
Copy link
Contributor

llbartekll commented Jul 14, 2022 •
edited
Loading

update session namespaces should be validated against proposed namespaces instead of first session namespaces.

it should be valid to replace an account
for example eip155: { accounts: [eip155:1:0xaaa...] } to eip155: { accounts: [eip155:1:0xbbb...] }

related PR: https://github.com/WalletConnect/WalletConnectSwiftV2/pull/276/files#diff-913ec54077d4df09639e3d649794d1b35585571ee0139902c43337bbc4a33894
@llbartekll llbartekll added the bug Something isn't working label Jul 14, 2022
@llbartekll llbartekll added this to the v2.0-rc.1 milestone Jul 14, 2022
@llbartekll llbartekll moved this to Todo in Swift SDK Jul 14, 2022
@sekimondre sekimondre mentioned this issue Jul 15, 2022
Merged
@llbartekll llbartekll moved this from Todo to In Review in Swift SDK Jul 15, 2022
llbartekll added a commit that referenced this issue Jul 15, 2022
@llbartekll
Merge pull request #342 from WalletConnect/bugfix/#340-required-names…
ac6a91c 
…paces

[Bugfix] #340: Required namespaces check
@llbartekll llbartekll moved this from In Review to Done in Swift SDK Jul 15, 2022
@flypaper0 flypaper0 mentioned this issue Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sekimondre sekimondre

Labels
bug Something isn't working
Projects
Swift SDK
Archived in project
Milestone
v2.0-rc.0
Development

No branches or pull requests
2 participants
@sekimondre @llbartekll