testHandleSessionProposeResponse MainActor removed

WalletConnect · Aug 8, 2022 · 345855a · 345855a
1 parent a7d4d88
commit 345855a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/Tests/WalletConnectSignTests/Mocks/NetworkingInteractorMock.swift b/Tests/WalletConnectSignTests/Mocks/NetworkingInteractorMock.swift
@@ -76,8 +76,8 @@ class NetworkingInteractorMock: NetworkInteracting {
     }
 
     func subscribe(topic: String) {
-        didCallSubscribe = true
         subscriptions.append(topic)
+        didCallSubscribe = true
     }
 
     func unsubscribe(topic: String) {

diff --git a/Tests/WalletConnectSignTests/PairingEngineTests.swift b/Tests/WalletConnectSignTests/PairingEngineTests.swift
@@ -85,8 +85,6 @@ final class PairingEngineTests: XCTestCase {
         XCTAssertEqual(publishTopic, topicA)
     }
 
-    // Flaky test: asserting `topicB` and `sessionTopic` failed once, couldn't reproduce
-    @MainActor
     func testHandleSessionProposeResponse() async {
         let uri = try! await engine.create()
         let pairing = storageMock.getPairing(forTopic: uri.topic)!
@@ -121,7 +119,7 @@ final class PairingEngineTests: XCTestCase {
 
         XCTAssertTrue(networkingInteractor.didCallSubscribe)
         XCTAssert(storedPairing.active)
-//        XCTAssertEqual(topicB, sessionTopic, "Responder engine calls back with session topic")
+        XCTAssertEqual(topicB, sessionTopic, "Responder engine calls back with session topic")
     }
 
     func testSessionProposeError() async {