399 reduce redundancy in row based forms #664
Open
+26
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there's a single option available in the crew check in/check out forms, it is automatically selected as default
Also, re-activate buttons for individual event check ins
2 tasks
Muirrum
requested changes
Sep 18, 2022
| @@ -461,8 +461,9 @@ def hours_prefill_self(request, id): | |||
| if not event.ccinstances.exists(): | |||
| raise PermissionDenied | |||
| if event.hours.filter(user=request.user).exists(): | |||
| messages.add_message(request, messages.ERROR, 'You already have hours for this event.') | |||
| messages.add_message(request, messages.ERROR, 'You are already checked in to this event.') | |||
There was a problem hiding this comment.
can you test to make sure that this does the expected? It looks like it'll error whenever a member has hours
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In crew checkin/out, select single radio buttons by default and autofill when only one option is accepted. In crew hours and CC assignments for events with one category of services, the category is selected by default.