positions: Add Position Postings #577

Muirrum · 2021-11-12T17:00:06Z

positions: Create position models and add app
positions: Add basic position templates
positions: Make reports_to field optional
positions: Enable editing and creation of new positions
positions: Add the "apply" permission
positions: Display a banner on the main page for open positions
positions: Enable Officers to "Add Positions" from the navbar

Closes #562. Allows officers to post positions within the DB and open them to
all active members. Active members are given the chance to apply via an external
form.

Per WPI-LNL#562, this creates a new django app for the position postings. The thought process behind the position flow is: 1. Exec posts a position 2. Active members can see that there are open positions, and can view them on the DB and apply with 1 click (side thought on displaying -- I was thinking something similar to the CC report reminders but on the main page) 3. Applicants are given a form to complete if provided by exec, and exec can see the applicants event/training history in the position view 4. Exec votes and does exec-y things to pick the person, who then gets a congratulatory email and the position is marked as closed. Writing this out, I need to add a field to the `Position` model to mark if the position has been filled.

This commit will add the following templates: - position_list - position_detail It will update the following models: - Position I'm debating just getting rid of the ApplicationInstance model entirely and letting exec track applications through their own external tools.

Some positions won't have any reports (e.g exec board positions posted so that potential candidates know what the job entails).

coveralls · 2021-11-12T17:06:25Z

Coverage increased (+0.03%) to 94.016% when pulling b596f59 on Muirrum:position-postings into 75d9545 on WPI-LNL:dev.

tnurse18 · 2021-11-12T17:25:20Z

Please open all new pull requests against the dev branch. Thank you!

tnurse18

There's a lot of good progress here, but there's still quite a ways to go. For one thing, you need to have test cases written for this. Please also consider writing up a User Guide on how to view the open positions and apply (if applicable).

events/views/indices.py

positions/models.py

positions/tests.py

site_tmpl/position_detail.html

site_tmpl/position_list.html

Previously, the template would error trying to reverse to the accounts detail page for None. It now defaults to "Exec Board" as a whole, unless a specific officer is set.

This will change the `closes` field in the positions app to a DateTime field, and the `application_form` field to be a URLField.

This will test every view for access control, as well as the `is_closed` method on Positions

Some positions do not require applications (e.g Executive board positions). See WPI-LNL#577 (comment) Signed-off-by: Cara Salter <[email protected]>

Muirrum · 2021-12-13T18:01:49Z

@tnurse18 Should be all set -- I'm going to write some documentation while I wait for a review.

Signed-off-by: Cara Salter <[email protected]>

Muirrum · 2021-12-17T19:23:41Z

This adds the standard CRUD permissions for Positions, as well as a custom permission for "Apply", that should be granted to Active members

tnurse18

Sorry it took so long to complete my review, but I finally have some feedback for you! Overall this is really coming together quite well. You've done an excellent job here and should be really proud of what you've accomplished so far. In addition to the comments I’ve made throughout, here are a couple more things to consider:

Now that your models seem to be just about ready to go, if you’re comfortable squashing down your migrations into one, that would be great. If not, I can take care of that for you before we merge to master.
Still missing documentation for adding a position.

tnurse18 · 2022-01-13T01:53:32Z

events/views/indices.py

@@ -80,6 +81,9 @@ def admin(request, msg=None):
        datetime_end__gte=(now - datetime.timedelta(hours=3))).distinct()
    context['selfcrew_events'] = selfcrew_events

+    open_positions = Position.objects.filter(closes__gte=timezone.now()).count()


This also excludes listings that don't have applications that close

tnurse18 · 2022-01-13T01:56:30Z

docs/help/positions/apply.rst

+Apply for a position
+====================
+
+Active members can now see a list of open leadership positions created by the


The title of the page is "Apply for a position", so maybe we should mention that they can do that here as well? Something like:

Active members can now view and apply for leadership opportunities online. New positions are posted regularly by the Executive Board.

tnurse18 · 2022-01-13T01:57:44Z

docs/help/positions/apply.rst

+-----------------
+To view a list of open positions, go to the "Members" dropdown and find the
+"Open Positions" link. Clicking that link will bring you to a list of positions
+that are currently looking for interested members.


Suggested change

that are currently looking for interested members.

that we are currently looking for candidates for.

tnurse18 · 2022-01-13T02:05:23Z

positions/models.py

+    should be created every time one needs to be filled.
+    """
+    name = models.CharField(verbose_name="Position Name", max_length=64,
+            null=False, blank=False)


This is redundant. Null and blank are False by default so they technically don't need to be specified. Not necessarily a problem, just reads a bit nicer in my opinion without them.

tnurse18 · 2022-01-13T02:06:36Z

positions/forms.py

+        self.helper.add_input(Submit('submit', 'Submit'))
+    class Meta:
+        model = Position
+        fields = ('name', 'description', 'position_start', 'position_end',


For the description field, you may want to consider using something like the Pagedown widget.

For the closes field you should definitely use the SplitDateTimeField.

reports_to should probably be a AutoCompleteSelectField.

There are tons of examples in other modules that you can look at if you need to.

tnurse18 · 2022-01-13T02:28:29Z

site_tmpl/position_detail.html

+<table class="table">
+	<tr>
+		<th>Description</th>
+		<td>{{ object.description }}</td>


I would consider using the markdown filter here. When I tried this out, I tried adding a list as part of my description, but that didn't display well.

tnurse18 · 2022-01-13T02:36:23Z

site_tmpl/position_detail.html

+	</tr>
+	<tr>
+		<th>Applications Close</th>
+		<td>{% if object.closes %}{{ object.closes }}{% else %}Doesn't


I would probably hide this row if there isn't an application.

tnurse18 · 2022-01-13T02:37:48Z

site_tmpl/position_list.html

+		<td><a href="{% url 'positions:detail' pos.id %}">{{ pos }}</a></td>
+		<td>{{ pos.position_start }}</td>
+		<td>{{ pos.position_end }}</td>
+		<td>{% if pos.closes %}{{ pos.closes }}{% else %}Does not


If there isn't an application, maybe something like Not applicable would be better here?

tnurse18 · 2022-01-13T03:05:44Z

positions/views.py

+    permission_required="positions.add_position"
+
+    def get_success_url(self):
+        return reverse("accounts:me")


This seemed a bit odd in my opinion and it definitely caught me by surprise. I think the user would be expecting to end up on either the position detail page or the open positions list.

tnurse18 · 2022-01-13T03:09:44Z

positions/views.py

+
+class ListPositions(PermissionRequiredMixin, LoginRequiredMixin, generic.ListView):
+    model = Position
+    queryset = Position.objects.filter(closes__gte=datetime.datetime.now())


You should definitely use timezone here instead

Suggested change

queryset = Position.objects.filter(closes__gte=datetime.datetime.now())

queryset = Position.objects.filter(closes__gte=timezone.now())

Muirrum added 8 commits November 4, 2021 11:40

positions: Make reports_to field optional

4bc0b6a

Some positions won't have any reports (e.g exec board positions posted so that potential candidates know what the job entails).

positions: Enable editing and creation of new positions

2689b2a

positions: Add the "apply" permission

cad9c57

positions: Display a banner on the main page for open positions

16e03d3

positions: Enable Officers to "Add Positions" from the navbar

6dad352

positions: Remove unneeded ApplicationInstance model

62f6a26

Muirrum mentioned this pull request Nov 12, 2021

Position Postings #572

Closed

tnurse18 requested changes Nov 12, 2021

View reviewed changes

Muirrum changed the base branch from master to dev November 14, 2021 18:55

Muirrum added 5 commits November 14, 2021 13:59

positions: Add edge case for no report

0bff9cd

Previously, the template would error trying to reverse to the accounts detail page for None. It now defaults to "Exec Board" as a whole, unless a specific officer is set.

positions: Use timezone-aware DateTimes

bab0c11

positions: Switch to DateTime and URL Fields

6e15861

This will change the `closes` field in the positions app to a DateTime field, and the `application_form` field to be a URLField.

positions: Add and fix tests

9c82530

This will test every view for access control, as well as the `is_closed` method on Positions

positions: Don't require an external application form

b926a9f

Some positions do not require applications (e.g Executive board positions). See WPI-LNL#577 (comment) Signed-off-by: Cara Salter <[email protected]>

Muirrum added 2 commits December 13, 2021 13:14

docs: Document positions app

d1906c8

Signed-off-by: Cara Salter <[email protected]>

Merge branch 'dev' into position-postings

b596f59

Muirrum requested a review from tnurse18 December 13, 2021 18:22

tnurse18 requested changes Jan 13, 2022

View reviewed changes

benjamin-antupit marked this pull request as draft September 18, 2022 20:30

alextannenbaum deleted the branch WPI-LNL:dev May 17, 2024 15:56

alextannenbaum closed this May 17, 2024

alextannenbaum reopened this May 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

positions: Add Position Postings #577

positions: Add Position Postings #577

Muirrum commented Nov 12, 2021

coveralls commented Nov 12, 2021 •

edited

Loading

tnurse18 commented Nov 12, 2021

tnurse18 left a comment

Muirrum commented Dec 13, 2021

Muirrum commented Dec 17, 2021

tnurse18 left a comment

tnurse18 Jan 13, 2022

tnurse18 Jan 13, 2022

tnurse18 Jan 13, 2022

tnurse18 Jan 13, 2022

tnurse18 Jan 13, 2022

tnurse18 Jan 13, 2022

tnurse18 Jan 13, 2022

tnurse18 Jan 13, 2022

tnurse18 Jan 13, 2022

tnurse18 Jan 13, 2022

	that are currently looking for interested members.
	that we are currently looking for candidates for.

	queryset = Position.objects.filter(closes__gte=datetime.datetime.now())
	queryset = Position.objects.filter(closes__gte=timezone.now())

positions: Add Position Postings #577

Are you sure you want to change the base?

positions: Add Position Postings #577

Conversation

Muirrum commented Nov 12, 2021

coveralls commented Nov 12, 2021 • edited Loading

tnurse18 commented Nov 12, 2021

tnurse18 left a comment

Choose a reason for hiding this comment

Muirrum commented Dec 13, 2021

Muirrum commented Dec 17, 2021

tnurse18 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 12, 2021 •

edited

Loading