This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Correct /posts/ endpoint read post permission logic #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WP-API/amigos #reviewmerge |
joehoyle
added a commit
that referenced
this pull request
Jan 28, 2015
Correct /posts/ endpoint read post permission logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #788
No longer passing $post by reference in
get_items()method of Posts Controller, instead using an array to gather posts once they pass the permission check.Added unit test to confirm logic is no longer flawed.
This was not an issue in any of the other endpoint Controllers.