-
Notifications
You must be signed in to change notification settings - Fork 658
Add latest client js including minified version #1981
Conversation
* Development happening at https://github.com/WP-API/client-js Full changeset: WP-API/client-js@22b1e42...477a49f Props: @delphinus35, @adamsilverstein, @westonruter Change highlights: * Api builds models and collections from Schema, no hard coded models or collections; any endpoint in the schema will be mapped; supports multiple schemas (apis); helper methods for post model: all helpers user _embed data if available, otherwise using ajax request. * new: Async load of api, apps can use the deferred to time startup * new: Ability to localize schema, falls back to making an ajax request & cached in session storage; develop branch of client js has code that only localizes data once per session * new Helper methods for Posts model: getCategories and setCategories * fix: cleanup TimeStampedMixin * new: models/collections get defaults and options from schema * fix: all code up to WordPress JavaScript coding standards * new: helper method to get post author user model `getAuthorUser` * new: helper method to get a featured image for a post: `getFeaturedImage` * new: models protect methods based on endpoint methods (eg. destory is blocked if an endpoint doesn't have a 'DELETE' method) * new: models contain a reference to the original route object * Ensure getters always return promise * Add remapping for names, see WP-API/client-js#75 * additional helpers: add getMeta, getTags, getRevisions #76 * When SCRIPT_DEBUG off, use minified script; update localized data
e079114
to
6a77c40
Compare
@westonruter updated the comparison link in commit and pr, thanks for the tip. i'm doing the comparison link for HEAD in clientjs against where we started with last merge so you can review the full commit log. |
force pushing my amended commit message resulted in a new commit hash: 6a77c40 |
Perfect 👍 |
@danielbachhuber are you keeping this open so it can be updated right before the Beta 11 release? Or can it be merged now? |
Heh. It didn't have the |
Add latest client js including minified version
@adamsilverstein Looks like this didn't include the |
@rmccue yes, i left that out on purpose: i don't want to localize the data on each page. I have a branch in the works that attempts to localize the data once and only once per session: https://github.com/WP-API/client-js/commits/features/only-localize-schma-once The JS should accommodate and make an ajax request for the schema data if its not localized. I thought I had checked this,assuming you cleared cache/opened a new window? I will dig back in and make sure this is working properly. In the mean time, copy the localized data build over from the client repo. |
@rmccue testing with latest develop, client js plugin disabled. not getting js errors, setup from ajax callback works fine. might be related to model name changes? what are the specific errors you are getting? |
Actually: I am getting a JS error now: |
Thanks for pointing that out - removing the default post processing fixes the issue with session storage: fixed in WP-API/client-js@06987b6 : update PR incoming |
Full changeset: WP-API/client-js@22b1e42...477a49f
Props: @delphinus35, @adamsilverstein, @westonruter
Change highlights:
getAuthorUser
getFeaturedImage