This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Use proper status code when failing to get comments of private post #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WP-API/amigos #reviewmerge |
| @@ -354,7 +354,7 @@ public function get_items_permissions_check( $request ) { | |||
| $post = get_post( (int) $request['post'] ); | |||
|
|
|||
| if ( $post && ! $this->check_read_post_permission( $post ) ) { | |||
| return new WP_Error( 'rest_cannot_read_post', __( 'Sorry, you cannot read the post for this comment.' ) ); | |||
| return new WP_Error( 'rest_cannot_read_post', __( 'Sorry, you cannot read the post for this comment.' ), array( 'status' => rest_authorization_required_code() ) ); | |||
There was a problem hiding this comment.
@danielbachhuber Would a 403 status code be more accurate here? Even if a user was logged-in they may not have permission to read private posts.
There was a problem hiding this comment.
rest_authorization_required_code() returns 401 when the user is logged out, and 403 when the user is logged in?
There was a problem hiding this comment.
401 is basically "if you are not logged in, login and retry, then we'll tell you if you can access this" so I think we are good.
danielbachhuber
added a commit
that referenced
this pull request
Dec 15, 2015
Use proper status code when failing to get comments of private post
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.