Return full post object when deleting post

[danielbachhuber]

See #1224

[danielbachhuber]

@WP-API/amigos #reviewmerge

[rachelbaker]

I would like @rmccue to weigh in here and in: #1255, #1254, and #1253

[rachelbaker]

From the HTTP spec for DELETE:

A successful response SHOULD be 200 (OK) if the response includes an entity describing the status, 202 (Accepted) if the action has not yet been enacted, or 204 (No Content) if the action has been enacted but the response does not include an entity.

I don’t know what an entity describing the status means

[rmccue]

$mock_request isn't really the right name, since this is a real request and "mock" has a specific meaning. $get_request?

[rmccue]

This generally looks OK to me. One thing we might want to consider is wrapping the post in another object (e.g. { data: {...}, trashed: true, gone: false }) to make it clear that the request did succeed (since we're meant to be describing the status), buuuuut that might be overkill.

[rmccue]

Also, should we consider this from #627?

if ( $new_status === 'trash' ) {
    // Send a 202 if it's only trashed to indicate that it will be
    // actually deleted later
    $response->set_status( 202 );

i.e. 200 = permanently deleted, 202 = trashed

Not sure we need the distinction now with the split from double-DELETE to separate trash/perma-delete, but worth thinking about.

[danielbachhuber]

Not sure we need the distinction now with the split from double-DELETE to separate trash/perma-delete, but worth thinking about.

See #1260