Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring3 migration #479

Merged
merged 21 commits into from
May 20, 2024
Merged

Spring3 migration #479

merged 21 commits into from
May 20, 2024

Conversation

07joshua03
Copy link
Contributor

@07joshua03 07joshua03 commented May 6, 2024 •
edited
Loading

TODO:

  • Fix ConstraintViolationExpection (see test results)
  • Remove trailing slashes everywhere and fix hrefs
  • Fix temporary removal of NonNull inside of Order
  • Migrate Spring boot 3.1 etc.
  • See if other issues arise
  • [ ]

@07joshua03
Updated spring boot to version 3.0
de518ac 
- Changed spring boot from 2.7 to 3.0
- Removed javax.el-api dependency (https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide#jakarta-ee)
- Updaed thymeleaf to use spring6 and springsecurity6
@07joshua03
Changed port to 8080 in devcontainer config so that logging in works
5c2d1b1
@07joshua03
Moved javax imports to jakarta
a346e24 
https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide#jakarta-ee
@07joshua03
Fix websecurityconfigureradapter
eaf0882 
Renamed authorizeRequests, antMatchers and ignoringMatchers to new versions
- https://spring.io/blog/2022/02/21/spring-security-without-the-websecurityconfigureradapter
- https://stackoverflow.com/questions/74609057/how-to-fix-spring-authorizerequests-is-deprecated
@07joshua03
Remove Java8TimeDialect
ecaf4fc 
TODO: Check whether this breaks anything
@07joshua03
Temp fix validation errors becuse of NotNull constraint in Order
7cebd72 
TODO: Figure out how to keep this constraint?
@07joshua03
Fix trailing slashes and html errs due to deprecated #httpServletRequest
2839847
@07joshua03
Fix first tests
eb6135d
@07joshua03 07joshua03 marked this pull request as draft May 7, 2024 09:41
@07joshua03
Copy link
Contributor Author

CodeQL will not work for now I think as per github/codeql-action#1855

Leading slashes should still be fixed, as the current path (see WebConfiguration.java) is already deprecated: 'The method setUseTrailingSlashMatch(Boolean) from the type PathMatchConfigurer is deprecated since version 6.0'

Beyond that, I think the migration is done.

@07joshua03 07joshua03 marked this pull request as ready for review May 9, 2024 18:59
@07joshua03 07joshua03 linked an issue May 9, 2024 that may be closed by this pull request
Upgrade to Spring Boot 3 #453
Closed
JoepdeJong
JoepdeJong approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@JoepdeJong JoepdeJong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Reviewed all changes and tested locally.

Please make a new issue for configurer.setUseTrailingSlashMatch(true);

src/main/java/ch/wisv/events/WebConfiguration.java Show resolved Hide resolved
JoepdeJong
JoepdeJong requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@JoepdeJong JoepdeJong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test the login with Connect, because its currently not running on my localhost. Can you make sure this still works?

@07joshua03
Copy link
Contributor Author

I did not test the login with Connect, because its currently not running on my localhost. Can you make sure this still works?

I tested it with connect, and this still works as expected

JoepdeJong
JoepdeJong approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@JoepdeJong JoepdeJong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@07joshua03 07joshua03 mentioned this pull request May 14, 2024
Open
@07joshua03 07joshua03 self-assigned this May 14, 2024
@JoepdeJong JoepdeJong changed the title [WIP] Spring3 migration Spring3 migration May 20, 2024
@JoepdeJong JoepdeJong merged commit 2785546 into master May 20, 2024
5 checks passed
JoepdeJong added a commit that referenced this pull request May 21, 2024
@JoepdeJong
Revert "Spring3 migration (#479)"
6c6dd54 
This reverts commit 2785546.
JoepdeJong added a commit that referenced this pull request May 21, 2024
@JoepdeJong
Revert "Spring3 migration (#479)"
d7c6211 
This reverts commit 2785546.
@dsluijk dsluijk deleted the spring3-migration branch July 28, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoepdeJong JoepdeJong JoepdeJong approved these changes

Assignees

@07joshua03 07joshua03

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Spring Boot 3
2 participants
@07joshua03 @JoepdeJong