Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove discrete inputs from openmdao wrapper #45

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Conversation

dzalkind
Copy link
Contributor

Purpose

Discrete inputs to RAFT openmdao wrapper were making it difficult to use optimization routines that use finite differencing. All the discrete inputs were changed to modeling options.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@dzalkind dzalkind changed the base branch from master to dev March 19, 2024 15:47
@dzalkind dzalkind changed the base branch from dev to master March 19, 2024 15:47
@mattEhall mattEhall merged commit 25bb2f3 into WISDEM:master Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants