-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganizing common costs in design modules #169
Conversation
…hgear for HVDC application
…ted added export_system output as expected input for oss_design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @nRiccobo! A few really minor things are noted throughout. I'd also just check on your references to be sure they all get produced in the documentation. I was under the impression that each time a reference is used it needed to be included in the docstring, but I could be mistaken here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, everything was cleared up on our call on Wednesday, so this is ready to go. Thanks again, @nRiccobo!
Several design modules employ common costs or cost rates for different components if the user does not specify their own value. While this only takes up about 1 line per call, the downside is that default values scattered among the design modules. This pull request reorganizes all those default values into ORBIT/core/default/common_cost.yaml so they can be more easily accessed and managed. Additionally, extra logic was incorporated to catch KeyErrors.