Reorganizing common costs in design modules #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hgear for HVDC application
…ted added export_system output as expected input for oss_design.
RHammond2
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Looks great, @nRiccobo! A few really minor things are noted throughout. I'd also just check on your references to be sure they all get produced in the documentation. I was under the impression that each time a reference is used it needed to be included in the docstring, but I could be mistaken here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several design modules employ common costs or cost rates for different components if the user does not specify their own value. While this only takes up about 1 line per call, the downside is that default values scattered among the design modules. This pull request reorganizes all those default values into ORBIT/core/default/common_cost.yaml so they can be more easily accessed and managed. Additionally, extra logic was incorporated to catch KeyErrors.