Skip to content

Updated README.md to have the way to handle the no fetch handler case and the empty fetch handler case. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Updated README.md to have the way to handle the no fetch handler case and the empty fetch handler case. #15

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f389c9
Update README.md
yoshisatoyanagisawa Dec 1, 2023
e250f1e
Merge branch 'WICG:main' into main
yoshisatoyanagisawa Dec 1, 2023
3dec6fa
Update README.md
yoshisatoyanagisawa Dec 1, 2023
99f65db
Update README.md
yoshisatoyanagisawa Dec 4, 2023
850f3c8
Update README.md
yoshisatoyanagisawa Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,24 @@ the original proposal. It is natural evolution to use `URLPattern` instead of U
To allow third party services to use the API, the method can be called multiple times.
* URL related conditions are merged into `URLPattern`.

### How does it work if there is no fetch handler?

For the "network" source, we can safely ignore the routes if there is no fetch handler, except for a debugging purpose.
In [the full picture](final-form.md), we introduce "cache", "fetch-event", and "race-network-and-fetch-handler" sources.
The "cache" source should look up a request from the cache storage even if there is no fetch handler.
Moreover, it does not need to run the fetch handlers regardless of cache hit or cache miss.
On the other hand, the "fetch-event" and "race-network-and-fetch-handler" sources run the fetch handlers.
`addRoutes()` should return a promise rejected with a *TypeError* if these sources are used while no fetch handlers are set.
Copy link
Collaborator

@sisidovski sisidovski Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good clarification 👍


### How does it work with [empty fetch listeners](https://github.com/yoshisatoyanagisawa/service-worker-skip-no-op-fetch-handler)?

If [all the fetch listeners are empty functions](https://w3c.github.io/ServiceWorker/#all-fetch-listeners-are-empty-algorithm),
routes may not be evaluated because routes expect some is handled by the fetch listeners while others are not.
If empty fetch listeners are set, routes should not be needed.
routes that only have the "network" source can be ignored, except for a debugging purpose.
Like the no fetch handler case above, the "cache" source should look up the cache storage regardless of the empty fetch handler or not.
However, unlike the no fetch handler case above,
`addRoutes()` should return a promise resolved with undefined for the "fetch-event" and "race-network-and-fetch-handler" sources
because the fetch handler exists.
During the navigation, the fetch handler may not need to run for these sources because they are empty.

### How does it work with Navigation Preload?

Expand Down