Skip to content

note that fragment directive is percent encoded using the standard percent encoded set #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

note that fragment directive is percent encoded using the standard percent encoded set #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,18 +187,20 @@ Fragments](https://www.w3.org/TR/media-frags/#media-fragment-syntax) (e.g.
#row=4).

The _text_ keyword will be used to identify a block of text that should be
indicated. The provided text is percent-decoded before matching. Dash (-),
ampersand (&), and comma (,) characters in text snippets must be
percent-encoded to avoid being interpreted as part of the text fragment
syntax.
indicated. The provided text must be percent encoded using the standard [percent
encode set](https://url.spec.whatwg.org/#percent-encoded-bytes) and is then
percent-decoded before matching. The percent encode set is inclusive of dash
(-), ampersand (&), and comma (,) as to avoid being interpreted as part of the
text fragment syntax.

The [URL standard](https://url.spec.whatwg.org/) specifies that a fragment can
contain [URL code points](https://url.spec.whatwg.org/#url-code-points), as
well as [UTF-8 percent encoded
contain [URL code points](https://url.spec.whatwg.org/#url-code-points), as well
as [UTF-8 percent encoded
characters](https://url.spec.whatwg.org/#utf-8-percent-encode). Characters in
the [fragment percent encode
set](https://url.spec.whatwg.org/#fragment-percent-encode-set) must be percent
encoded.
encoded. Fragment directive requires the more restrictive [percent encode
set](https://url.spec.whatwg.org/#percent-encoded-bytes).
Copy link
Collaborator

@bokand bokand Aug 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refers to a "set" but links to instructions on how to percent encode/decode. Should we link instead to the scroll-to-text-fragment spec instead?


There are two kinds of terms specified in the text directive: the _match_ and
the _context_. The match is the portion of text that’s to be indicated. The
Expand Down Expand Up @@ -287,7 +289,8 @@ Since the text “United States” is ambiguous, we must provide a suffix to dis
### Multiple Text Directives

Users can specify multiple snippets by providing additional text directives in
the _fragment directive_, separated by the ampersand (&) character.
the _fragment directive_, separated by the ampersand (&) character. Fragment
directives must be percent encoded.

Each `text=` directive is considered independent in the sense that success or
failure to match in one does not affect matching of any others. Each starts
Expand Down