Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to JSON-based Jest tests #204

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Conversation

hiroshige-g
Copy link
Collaborator

@hiroshige-g hiroshige-g commented Jan 29, 2020

In order to share common structure with Web Platform Tests #170,
this PR migrates hard-coded Jest tests into
JSON test metadata (__tests__/json/*.json, which are shared with
https://github.com/web-platform-tests/wpt/tree/master/import-maps/common/resources)
and test runners (__tests__/helpers/, which are Jest-specific).

In order to share common structure with Web Platform Tests,
this PR migrates hard-coded Jest tests into
JSON test metadata (`__tests__/json/*.json`, which are shared with
https://github.com/web-platform-tests/wpt/tree/master/import-maps/common/resources)
and test runners (`__tests__/helpers/`, which are Jest-specific).
@hiroshige-g
Copy link
Collaborator Author

@domenic WDYT?

Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

In the future I'll probably want to pull the JSON files in from the web platform tests repo directly so that we only have one source of truth. But for now this is perfect.

@domenic domenic merged commit 6cb173d into WICG:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants