Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '[SecureContext]` tags to the interfaces #224

Closed
wants to merge 2 commits into from

Conversation

OnkarRuikar
Copy link

@OnkarRuikar OnkarRuikar commented Feb 5, 2024

w3c/webref repo automatically extracts syntaxes from these spec docs. At the moment some syntax sections are missing the [SecureContext] tags so it is missing from extracted data in webref as well.

The feature has been marked secure in MDN docs.

The PR adds the tags to the remaining interfaces.


Preview | Diff

@annevk
Copy link
Collaborator

annevk commented Feb 5, 2024

I think these end up being redundant because the interfaces they are extending are already limited to secure contexts. We usually don't specify things redundantly.

@OnkarRuikar
Copy link
Author

I think these end up being redundant because the interfaces they are extending are already limited to secure contexts. We usually don't specify things redundantly.

I see. What about ExtendableCookieChangeEvent

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@annevk
Copy link
Collaborator

annevk commented Feb 5, 2024

If you're only exposed to the ServiceWorker global you are by definition limited to secure contexts because the ServiceWorker global is only exposed to secure contexts.

@OnkarRuikar
Copy link
Author

If you're only exposed to the ServiceWorker global you are by definition limited to secure contexts because the ServiceWorker global is only exposed to secure contexts.

@annevk We want to make it explicit so that the automated w3c/webref extractor can pick this fact correctly.

@annevk
Copy link
Collaborator

annevk commented Feb 5, 2024

I don't think we want to add redundancy to standards for the benefit of tooling. Instead the tooling should be fixed. Could you file an issue against w3c/webref? Feel free to at-mention me if you think that would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants