Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epsilon section to README #1439

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Conversation

giladbarkan-github
Copy link
Collaborator

@giladbarkan-github giladbarkan-github commented Sep 19, 2024

Adding visibility to epsilon search could help consumers become more acquainted
with the feature and help elicit feedback about adding such automation to
clients.

(https://wicg.github.io/attribution-reporting-api/#source-registration-json-key-event_level_epsilon)

@csharrison
Copy link
Collaborator

Hey Gilad can you point to the spec associated with this feature?

@giladbarkan-github
Copy link
Collaborator Author

Hey Gilad can you point to the spec associated with this feature?

Sure! My only concern would be if the link might change in the future, it's hard to keep track of where it's used.

@giladbarkan-github
Copy link
Collaborator Author

Hey Gilad can you point to the spec associated with this feature?

Sure! My only concern would be if the link might change in the future, it's hard to keep track of where it's used.

Done.

@csharrison
Copy link
Collaborator

Oh sorry I am fine with adding it to the explainer, but I would have been fine just adding it to the PR description too :)

@giladbarkan-github
Copy link
Collaborator Author

Oh sorry I am fine with adding it to the explainer, but I would have been fine just adding it to the PR description too :)

Lol, done!

@csharrison
Copy link
Collaborator

Hm you linked to event_level_epsilon definition but not the search feature. Where is that specified?

@giladbarkan-github
Copy link
Collaborator Author

Hm you linked to event_level_epsilon definition but not the search feature. Where is that specified?

I'm confused. We haven't spec'd an automated search feature. This README update is to call out functionality available with the flexible event JavaScript script.

@csharrison
Copy link
Collaborator

🤦 sorry I totally misread your PR. Apologies

@linnan-github linnan-github merged commit f5ec3bb into WICG:main Sep 23, 2024
2 checks passed
@giladbarkan-github giladbarkan-github deleted the epsilon2 branch October 17, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants