Replace CRA with Vite; COUNTRY=cambodia#1210
Conversation
frontend/src/components/MapView/LeftPanel/AnalysisPanel/ExposureAnalysisActions/index.tsx
Outdated
Show resolved
Hide resolved
@ericboucher - I am consistently hitting the same error on this branch, but not on main. I made a surge deploy and am seeing the same issue there: https://tan-stickz.surge.sh/ |
|
@wadhwamatic looking at the error you're getting in your deployed branch I think you need to run |
Thanks @ericboucher. I was just doing a clean yarn install, not setup common. This addressed the issue I was seeing. I do get an error when I run setup:common, but it seems to not affect the app. |
|
I ran into the same issue @wadhwamatic described above in node-pre-gyp. I believe it stems from react-pdf Automattic/node-canvas#2186 |
|
Heads up, @ericboucher and @echaidemenos, the canvas package is a dependency to react-pdf but has caused a lot of folks issues during installs (see: https://www.google.com/search?q=canvas+node-pre-gyp). Because we're not making use of this package in our usage of react-pdf, I removed the dependency by overwriting it in package.json. Amit and I have confirmed that pdf print outs are still functioning as expected after removing this dependency. Let me know if you see any issues with this solution cc: @wadhwamatic |
|
Works for me @gislawill. Does this PR look good to go otherwise? |
gislawill
left a comment
There was a problem hiding this comment.
Looks good to me. Really excited for this one
Description
Replaces CRA with Vite.
Aims to speed up development.
Important note: mui/material-ui#32685 (comment) and #1302
Things to QA
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn startREACT_APP_COUNTRY=cambodia yarn startREACT_APP_COUNTRY=mozambique yarn startScreenshot/video of feature: