Builds #130
Merged
Builds #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more progress on builds: list, delete added delete doesn't work yet trying to track down builds issue for delete fix delete, add list builds for user (or all for owner, allows auditing) allow bot owner to delete builds change default build image to a smaller version add and fetch builds next up: - [ ] editing individual fields - [ ] private builds? - [ ] deleting builds more progress on builds: list, delete added delete doesn't work yet trying to track down builds issue for delete fix delete, add list builds for user (or all for owner, allows auditing) allow bot owner to delete builds change default build image to a smaller version Merge remote-tracking branch 'origin/builds' into builds
stickler-ci
reviewed
Oct 3, 2017
src/settings/Database.js
Outdated
| return res[0].map(build => ({ | ||
| id: build.build_id, | ||
| owner: this.bot.client.users.get(build.owner_id) || build.owner_id, | ||
| title: build.title |
There was a problem hiding this comment.
Missing trailing comma. (comma-dangle)
stickler-ci
reviewed
Oct 3, 2017
src/commands/Builds/ListBuilds.js
Outdated
| const buildGroups = createGroupedArray(builds, 20); | ||
| const tokens = buildGroups.map(buildGroup => ({ name: '_ _', value: buildGroup.map(build => `\`${build.id} | ${build.title} | Owned by ${typeof build.owner === 'object' ? build.owner.tag : build.owner}\``).join('\n') })); | ||
| const tokenGroups = createGroupedArray(tokens, 6); | ||
| await Promise.all(tokenGroups.map(tokenGroup => { |
There was a problem hiding this comment.
Expected parentheses around arrow function argument having a body with curly braces. (arrow-parens)
stickler-ci
reviewed
Oct 3, 2017
src/commands/Builds/ListBuilds.js
Outdated
| const tokens = buildGroups.map(buildGroup => ({ name: '_ _', value: buildGroup.map(build => `\`${build.id} | ${build.title} | Owned by ${typeof build.owner === 'object' ? build.owner.tag : build.owner}\``).join('\n') })); | ||
| const tokenGroups = createGroupedArray(tokens, 6); | ||
| await Promise.all(tokenGroups.map(tokenGroup => { | ||
| tokenGroup[0].fields.value = `\`Build ID | Title | Owner\`\n${tokenGroup[0].fields.value}`); |
stickler-ci
reviewed
Oct 3, 2017
src/commands/Builds/ListBuilds.js
Outdated
| const tokens = buildGroups.map(buildGroup => ({ name: '_ _', value: buildGroup.map(build => `\`${build.id} | ${build.title} | Owned by ${typeof build.owner === 'object' ? build.owner.tag : build.owner}\``).join('\n') })); | ||
| const tokenGroups = createGroupedArray(tokens, 6); | ||
| await Promise.all(tokenGroups.map(tokenGroup => { | ||
| tokenGroup[0].fields.value = `\`Build ID | Title | Owner\`\n${tokenGroup[0].fields.value}`; |
There was a problem hiding this comment.
Assignment to property of function parameter 'tokenGroup'. (no-param-reassign)
stickler-ci
reviewed
Oct 3, 2017
src/commands/Builds/ListBuilds.js
Outdated
| const tokens = buildGroups.map(buildGroup => ({ name: '_ _', value: buildGroup.map(build => `\`${build.id} | ${build.title} | Owned by ${typeof build.owner === 'object' ? build.owner.tag : build.owner}\``).join('\n') })); | ||
| const tokenGroups = createGroupedArray(tokens, 6); | ||
| await Promise.all(tokenGroups.map(tokenGroup => { | ||
| tokenGroup[0].value = `\`Build ID | Title | Owner\`\n${tokenGroup[0].fields.value}`; |
There was a problem hiding this comment.
Assignment to property of function parameter 'tokenGroup'. (no-param-reassign)
stickler-ci
reviewed
Oct 3, 2017
src/commands/Builds/ListBuilds.js
Outdated
| const tokens = buildGroups.map(buildGroup => ({ name: '_ _', value: buildGroup.map(build => `\`${build.id} | ${build.title} | Owned by ${typeof build.owner === 'object' ? build.owner.tag : build.owner}\``).join('\n') })); | ||
| const tokenGroups = createGroupedArray(tokens, 6); | ||
| await Promise.all(tokenGroups.map(tokenGroup => { | ||
| tokenGroup[0].value = `\`Build ID | Title | Owner\`\n${tokenGroup[0].value}`; |
There was a problem hiding this comment.
Assignment to property of function parameter 'tokenGroup'. (no-param-reassign)
Contributor
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.