Make use of ES7 async when possible #122

Kaptard · 2017-09-03T21:32:42Z

Moved basic error logging to main.js as global exception handler. (no more .catch(this.logger.error))
Made use of ES7 async in the main modules for now. I recommend testing this, before starting with commands. (Will append commits to this PR)

TobiTenno · 2017-09-05T04:16:51Z

fix for #117

Kaptard · 2017-09-06T12:38:27Z

Just looked through c5ca908 and noticed there's a lot of async usage without actually awaiting anything. With help.js as example, did you mean to wait until each of those embeds are finished and only then return this.messageManager.statuses.SUCCESS?

TobiTenno · 2017-09-06T14:14:28Z

It's intended for help, that needs a further rewrite right now as it is, so i'm waiting for other enhancements on that one for afterward.

TobiTenno

Just a couple small changes or talking points for us.

Do we want to finish this pass on the commands, do the core utilities like database/settings and messageManager and then come back and do a second pass on the commands?

TobiTenno · 2017-09-06T19:39:04Z

src/commands/Owner/Avatar.js

-    .then(() => this.messageManager.reply(message, 'New avatar set!', true, true))
-    .catch(this.logger.error);
+    await this.bot.client.user.setAvatar(url);
+    this.messageManager.reply(message, 'New avatar set!', true, true);


could you add the success returns for when it succeeds when the message is sent?

TobiTenno · 2017-09-06T19:39:40Z

src/commands/Owner/LeaveServer.js

+      const guild = await this.bot.client.guilds.get(serverid).leave();
+      this.messageManager.reply(message, `Left ${guild.name}`, true, true);
    } else {
      message.reply('No such guild cached');


similar to Avatar, could you have an ❌ response after 'No such guild cached'?

TobiTenno · 2017-09-06T19:40:24Z

src/commands/Owner/Reload.js

    const commandsRemovedString = commandsRemoved.length > 0 ? commandsRemoved.sort().join(' ') : ' No Commands Removed';

-    this.messageManager.sendMessage(message, `${this.md.codeMulti}Commands reloaded!${this.md.blockEnd}` +
+    await this.messageManager.sendMessage(message, `${this.md.codeMulti}Commands reloaded!${this.md.blockEnd}` +


we probably want to look at returning the values from the operations in the messageManager functions so that these and successes make more sense.

TobiTenno · 2017-09-06T19:42:48Z

src/commands/Roles/Roles.js

+      const longest = roles.map(role => role.name)
+        .reduce((a, b) => (a.length > b.length ? a : b));
+      const groupedRoles = createGroupedArray(roles, 20);
+      const metaGroups = createGroupedArray(groupedRoles, 4);


this is more a criticism of my own code, but we could probably just wrap the second createGroupedArray call around the result of the first, since the first isn't used independently.

TODO: * Worldstate commands * database calls * message manager overhaul

- still need work to resolve conflicts on notifier class not recognizing functions

Removed double "custom commands" tokens await notifier starting

stickler-ci · 2017-09-18T03:05:57Z

src/embeds/ProfileEmbed.js

-                ? `${player.marked.stalker ? '<:stalker:330021480169603076>' : ''} ` +
+      {
+        name: 'Current Mastery',
+        value: player.mastery.xp,


Expected indentation of 10 spaces but found 8. (indent)

stickler-ci · 2017-09-18T03:05:57Z

src/embeds/ProfileEmbed.js

+      {
+        name: 'Current Mastery',
+        value: player.mastery.xp,
+        inline: true,


Expected indentation of 10 spaces but found 8. (indent)

stickler-ci · 2017-09-18T03:05:58Z

src/embeds/ProfileEmbed.js

+        name: 'Current Mastery',
+        value: player.mastery.xp,
+        inline: true,
+      },


Expected indentation of 8 spaces but found 6. (indent)

stickler-ci · 2017-09-18T03:05:58Z

src/embeds/ProfileEmbed.js

+        value: player.mastery.xp,
+        inline: true,
+      },
+      {


Expected indentation of 8 spaces but found 6. (indent)

stickler-ci · 2017-09-18T03:05:59Z

src/embeds/ProfileEmbed.js

+        inline: true,
+      },
+      {
+        name: 'Next Rank',


Expected indentation of 10 spaces but found 8. (indent)

stickler-ci · 2017-09-18T03:05:59Z

src/embeds/ProfileEmbed.js

+      },
+      {
+        name: 'Next Rank',
+        value: `${player.mastery.xpUntilNextRank} until **${player.mastery.rank.next}**`,


Expected indentation of 10 spaces but found 8. (indent)

stickler-ci · 2017-09-18T03:05:59Z

src/embeds/ProfileEmbed.js

+      {
+        name: 'Next Rank',
+        value: `${player.mastery.xpUntilNextRank} until **${player.mastery.rank.next}**`,
+        inline: true,


Expected indentation of 10 spaces but found 8. (indent)

stickler-ci · 2017-09-18T03:06:00Z

src/embeds/ProfileEmbed.js

+        name: 'Next Rank',
+        value: `${player.mastery.xpUntilNextRank} until **${player.mastery.rank.next}**`,
+        inline: true,
+      },


Expected indentation of 8 spaces but found 6. (indent)

stickler-ci · 2017-09-18T03:06:00Z

src/embeds/ProfileEmbed.js

+        value: `${player.mastery.xpUntilNextRank} until **${player.mastery.rank.next}**`,
+        inline: true,
+      },
+      {


Expected indentation of 8 spaces but found 6. (indent)

stickler-ci · 2017-09-18T03:06:01Z

src/embeds/ProfileEmbed.js

+        inline: true,
+      },
+      {
+        name: 'Clan',


Expected indentation of 10 spaces but found 8. (indent)

stickler-ci · 2017-09-18T03:06:01Z

src/embeds/ProfileEmbed.js

+      },
+      {
+        name: 'Clan',
+        value: player.clan.type ? `${player.clan.name}\nRank **${player.clan.rank}** ${player.clan.type}` : player.clan.name,


Expected indentation of 10 spaces but found 8. (indent)

stickler-ci · 2017-09-18T03:06:02Z

src/embeds/ProfileEmbed.js

+      {
+        name: 'Clan',
+        value: player.clan.type ? `${player.clan.name}\nRank **${player.clan.rank}** ${player.clan.type}` : player.clan.name,
+        inline: true,


Expected indentation of 10 spaces but found 8. (indent)

stickler-ci · 2017-09-18T03:06:02Z

src/embeds/ProfileEmbed.js

+        name: 'Clan',
+        value: player.clan.type ? `${player.clan.name}\nRank **${player.clan.rank}** ${player.clan.type}` : player.clan.name,
+        inline: true,
+      },


Expected indentation of 8 spaces but found 6. (indent)

stickler-ci · 2017-09-18T03:06:02Z

src/embeds/ProfileEmbed.js

+        value: player.clan.type ? `${player.clan.name}\nRank **${player.clan.rank}** ${player.clan.type}` : player.clan.name,
+        inline: true,
+      },
+      {


Expected indentation of 8 spaces but found 6. (indent)

stickler-ci · 2017-09-18T03:06:03Z

src/embeds/ProfileEmbed.js

+        inline: true,
+      },
+      {
+        name: 'Marked for Death',


Expected indentation of 10 spaces but found 8. (indent)

stickler-ci · 2017-09-18T03:06:03Z

src/embeds/ProfileEmbed.js

+      },
+      {
+        name: 'Marked for Death',
+        value: (player.marked.stalker || player.marked.g3 || player.marked.zanuka)


Expected indentation of 10 spaces but found 8. (indent)

stickler-ci · 2017-09-18T03:06:03Z

src/embeds/ProfileEmbed.js

-          inline: true,
-        });
+          : 'Unmarked',
+        inline: true,


Expected indentation of 10 spaces but found 8. (indent)

stickler-ci · 2017-09-18T03:06:04Z

src/embeds/ProfileEmbed.js

-        });
+          : 'Unmarked',
+        inline: true,
+      });


Expected indentation of 8 spaces but found 6. (indent)

stickler-ci · 2017-09-18T03:14:08Z

main.js

- * Raven client for logging errors and debugging events
- * @type {Raven}
- */
+const NexusFetcher = require('nexus-stats-api');


Unable to resolve path to module 'nexus-stats-api'. (import/no-unresolved)

stickler-ci · 2017-09-18T03:18:06Z

main.js

- * Raven client for logging errors and debugging events
- * @type {Raven}
- */
+const NexusFetcher = require('nexus-stats-api');


Unable to resolve path to module 'nexus-stats-api'. (import/no-unresolved)

another attemp to fix false positive (this is only happening on stickler-ci, so no idea why)

TobiTenno · 2017-09-19T18:40:30Z

merging.

wfcd-bot-boi · 2021-11-27T23:50:26Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

GitHub release
v1.0.0

Your semantic-release bot 📦🚀

Kaptard added 4 commits September 3, 2017 22:57

Let raven handle errors globally

ec135bd

Apply ES7 async to main controllers

9e8d674

Let raven handle errors globally

63c0c82

Apply ES7 async to main controllers

e86ca4d

TobiTenno force-pushed the master branch from 9e8d674 to e86ca4d Compare September 3, 2017 21:56

TobiTenno added 2 commits September 3, 2017 20:54

fix for failing database call, implement async responses on commands

044671c

async/await for more commands

c5ca908

TobiTenno added the Status: In Progress Work has Begun label Sep 5, 2017

Merge branch 'master' of https://github.com/kaptard/genesis

cea90a1

async for owner/role commands

d8a3e94

TobiTenno requested changes Sep 6, 2017

View reviewed changes

Kaptard and others added 6 commits September 7, 2017 00:37

Let raven handle errors globally

8e72f82

Apply ES7 async to main controllers

5a0a628

fix for failing database call, implement async responses on commands

2c86ae6

async/await for more commands

60067f2

async for owner/role commands

c8bca37

async settings command

c1c35c0

TobiTenno force-pushed the master branch from d8db598 to c1c35c0 Compare September 7, 2017 05:39

TobiTenno and others added 9 commits September 9, 2017 00:41

doc and returns

de23596

Overhaul rooms, settings, silly, utilities, and welcoming

411844a

TODO: * Worldstate commands * database calls * message manager overhaul

Merge branch 'master' of https://github.com/kaptard/genesis

69857d3

async for worldstate commands

081829e

Add return status & remove jsdoc from worldstate commands

39569cc

progress on notifier es7 changes

03d7b57

dependency updates, notifier uplift

404fd37

- still need work to resolve conflicts on notifier class not recognizing functions

Notifier fixes

e41cc3d

Removed double "custom commands" tokens await notifier starting

Merge branch 'master' into master

f745a6f

stickler-ci reviewed Sep 18, 2017

View reviewed changes

src/embeds/ProfileEmbed.js Outdated

value: player.mastery.xp,

inline: true,

},

{

Copy link

stickler-ci Sep 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 8 spaces but found 6. (indent)

stickler-ci reviewed Sep 18, 2017

View reviewed changes

src/embeds/ProfileEmbed.js Outdated

inline: true,

},

{

name: 'Next Rank',

Copy link

stickler-ci Sep 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 10 spaces but found 8. (indent)

stickler-ci reviewed Sep 18, 2017

View reviewed changes

src/embeds/ProfileEmbed.js Outdated

inline: true,

},

{

name: 'Clan',

Copy link

stickler-ci Sep 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 10 spaces but found 8. (indent)

stickler-ci reviewed Sep 18, 2017

View reviewed changes

src/embeds/ProfileEmbed.js Outdated

});

: 'Unmarked',

inline: true,

});

Copy link

stickler-ci Sep 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 8 spaces but found 6. (indent)

TobiTenno force-pushed the master branch from efda5e5 to 0e00813 Compare September 18, 2017 03:13

stickler-ci reviewed Sep 18, 2017

View reviewed changes

disable buggy import false-positive

269137b

stickler-ci reviewed Sep 18, 2017

View reviewed changes

TobiTenno added 2 commits September 17, 2017 22:22

05d7d85

another attemp to fix false positive (this is only happening on stickler-ci, so no idea why)

move some async aspects to an init

d50307d

TobiTenno merged commit cfdda08 into WFCD:master Sep 19, 2017

TobiTenno removed the Status: In Progress Work has Begun label Sep 19, 2017

snyk-bot mentioned this pull request Dec 10, 2020

[Snyk] Upgrade ms from 2.1.2 to 2.1.3 #423

Merged

wfcd-bot-boi added the released label Nov 28, 2021

Make use of ES7 async when possible #122

Make use of ES7 async when possible #122

Uh oh!

Conversation

Kaptard commented Sep 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TobiTenno commented Sep 5, 2017

Uh oh!

Kaptard commented Sep 6, 2017

Uh oh!

TobiTenno commented Sep 6, 2017

Uh oh!

TobiTenno left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TobiTenno commented Sep 19, 2017

Uh oh!

wfcd-bot-boi commented Nov 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kaptard commented Sep 3, 2017 •

edited

Loading