Adds ability to set android ring tone on success/error #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevePotter
reviewed
Sep 25, 2018
| @@ -161,6 +161,7 @@ Returns a promise with the string ID of the upload. Will reject if there is a c | |||
| |`enabled`|boolean|Optional|Enable or diasable notifications|`{ enabled: true }`| | |||
| |`autoClear`|boolean|Optional|Autoclear notification on complete|`{ autoclear: true }`| | |||
| |`notificationChannel`|string|Optional|Sets android notificaion channel|`{ notificationChannel: "My-Upload-Service" }`| | |||
| |`enableRingTone`|boolean|Optional|Sets whether or not to enable the notification sound when the upload gets completed with success or error|`{ enableRingTone: true }`| | |||
There was a problem hiding this comment.
Please indicate this is android-only. Also if you could alphabetize the props, I'd appreciate it
There was a problem hiding this comment.
@StevePotter I've added this to the header. The complete notification object is android only
StevePotter
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables us to set the
setRingToneEnabled(Boolean enabled)on theUploadNotificationConfigon Android.I've added the property
enableRingToneto the notification object to allow users to activate this feature.