Support iOS assets-library url #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSMMark
approved these changes
Feb 8, 2018
ios/VydiaRNFileUploader.m
Outdated
| PHAssetResource *assetResource = [[PHAssetResource assetResourcesForAsset:asset] firstObject]; | ||
| NSString *pathToWrite = [NSTemporaryDirectory() stringByAppendingPathComponent:[[NSUUID UUID] UUIDString]]; | ||
| NSURL *pathUrl = [NSURL fileURLWithPath:pathToWrite]; | ||
| fileURI = pathUrl.absoluteString; |
There was a problem hiding this comment.
What is the format or value of fileURI after being set to pathUrl.absoluteString;?
There was a problem hiding this comment.
file://blahblahblah
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you upload a file directly from the photo library, you previously had to copy the asset into a temporary file, which some picker libraries apparently don't support. Now the upload library supports that natively.
I did it by just copying the asset to a file. iOS had no support for directly uploading them. The best approach I found, and I researched a bunch, was from https://stackoverflow.com/questions/33278540/phasset-afnetworking-upload-multiple-videos
I took advantage of ObjC dispatch groups to make the actual implementation pretty straightforward.