Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return headers on successful response #265

Merged
merged 2 commits into from
Jul 17, 2021
Merged

Return headers on successful response #265

merged 2 commits into from
Jul 17, 2021

Conversation

JF-23
Copy link
Contributor

@JF-23 JF-23 commented Jul 7, 2021

…esful responses along with params value

Summary

We're performing multipart uploads to s3, once all parts are uploaded we need to let aws know that the file is ready to be put back together by sending back all header values for each part uploaded. Having access to headers helps us to be able to let aws know past files have been successfully uploaded.

This is a simple change that is changes androids GlobalRequestObserverDelegate

We've been testing this simple update and have had good success with it, we believe it might be helpful for others.

| OS | Implemented |
| Android | ✅ |

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I've added Detox End-to-End Test(s)
  • I've created a snack to demonstrate the changes: LINK HERE

@reime005
Copy link
Collaborator

nice!

@reime005 reime005 merged commit cbc3951 into Vydia:master Jul 17, 2021
github-actions bot pushed a commit that referenced this pull request Jul 17, 2021
# [6.4.0](v6.3.0...v6.4.0) (2021-07-17)

### Features

* Return headers on successful response ([#265](#265)) ([cbc3951](cbc3951))
@github-actions
Copy link

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants