Use android version from root project. Update kotlin to 1.4.0 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TikiTDO
changed the title
|
@TikiTDO very cool! we missed that before, thanks |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2020
# [6.2.0](v6.1.0...v6.2.0) (2020-09-08) ### Features * [Android] Use root project SDK. Update kotlin to 1.4.0 ([#216](#216)) ([b8eaa84](b8eaa84))
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
benjamin777dev
added a commit
to benjamin777dev/react-native-upload
that referenced
this pull request
Jun 10, 2024
# [6.2.0](Vydia/react-native-background-upload@v6.1.0...v6.2.0) (2020-09-08) ### Features * [Android] Use root project SDK. Update kotlin to 1.4.0 ([#216](Vydia/react-native-background-upload#216)) ([b8eaa84](Vydia/react-native-background-upload@b8eaa84))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses 2 issues:
Android build was not respecting the SDK config of the root project, causing really weird build errors if the version I had configured was not 29. This PR adds code to use the target/compile version from the project using the lib.
The version of Kotlin that was configured did not work with my environment. This PR bumps the version to 1.4.0, and fixes a compile time error in android.
Test Plan
Majority of changes are to the build environment. Only code change is to fix a build-time "smart cast is impossible" error.
To test build an app that uses this library. Perform an upload.
Compatibility
Checklist