Cancel uploads #19
Merged
Cancel uploads #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ox-michaelradionov any progress on this one? |
|
@StevePotter Sorry, I completely forgot about this one. I'll be back to my mobile apps in the nearest week, so I'll be able to check if everything works as intended in this PR. Thank you for reminding me about it. |
|
Alright, I will cherry pick from your files with a fresh PR. master has
changed enough that going that route might be the best approach. I'll take
care of it one of these weekends. Then I'll just close out your PR.
Thanks!
…On Thu, Apr 27, 2017 at 10:34 AM, Michael Radionov ***@***.*** > wrote:
@StevePotter <https://github.com/StevePotter> Sorry, I completely forgot
about this one. I'll be back to my mobile apps in the nearest week, so I'll
be able to check if everything works as intended in this PR. Thank you for
reminding me about it.
I've noticed that you've migrated to RN 0.40+, but I am still on 0.39 so I
won't be able to test in on 0.40+.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQi_0n0aQ3jUofCixvgeFOKTUoyIICNks5r0KdhgaJpZM4MZgLR>
.
--
Stephen Potter,
Developer @ Vydia.com
|
|
Ok, I am fine with that, thank you. |
ox-michaelradionov
force-pushed
the
cancel-upload
branch
from
08dc3ba
to
a762cee
Compare
ox-michaelradionov
force-pushed
the
cancel-upload
branch
from
a762cee
to
b1e8b50
Compare
|
I've resolved all the conflicts and tested it against the latest version of the package. Works great for me. |
|
Is there any update to this? Would love to have support for cancellations. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method for cancelling active upload by upload ID.
Fires an event "cancelled" with ID of the cancelled upload.
Method returns a promise with boolean whether cancel was executed successfully or not.
I've changed a bit how customUploadId is handled on Android,
BinaryUploadRequestfromandroid-upload-servicealso accepts a custom ID for upload. (http://gotev.github.io/android-upload-service/javadoc/) , constructors:so in order to be able to cancel an upload by id,
android-upload-serviceshould also be aware of this id. I am using second constructor definition to pass a custom id to the service.