-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Test App and E2E tests #174
Conversation
Thanks @reime005 please consider merging with https://github.com/Vydia/ReactNativeBackgroundUploadExample or update readme if not obvious enough in the readme to know it exists https://github.com/Vydia/react-native-background-upload#faqs |
@TSMMark Oh, I haven't seen that. Should have read the readme more I guess. But anyway, don't you think that tests should be included in the main repository, so that you don't have to use a separate codebase just for testing? |
I didn't see any tests in this PR but I could have missed them? Or you mean just having an app to test with manually? I'd be happy to merge an example app with this repo, certainly. If you get a chance check out the existing example app and see if your test app is missing any features that exist already |
This file: TestApp/e2e/upload.e2e.js includes some very simple tests. I will merge the example app into this branch |
1a2e20c
to
0f27ac8
Compare
8a63805
to
d324a5a
Compare
@TSMMark I've merged the example app into this repo, added E2E tests for both platforms and added Github Actions CI/CD with semantic-release. Would be great if you could check it out and configure the NPM_TOKEN (Settings -> Secrets) as well as enable Github branch-protection to require successful checks for a pull request |
691b5b0
to
cd7eb77
Compare
36ffc50
to
8181cf0
Compare
# [5.2.0](v5.1.0...v5.2.0) (2020-03-22) ### Features * adding e2e tests, build automation and linting ([#174](#174)) ([d0ee16e](d0ee16e))
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [5.2.0](Vydia/react-native-background-upload@v5.1.0...v5.2.0) (2020-03-22) ### Features * adding e2e tests, build automation and linting ([#174](Vydia/react-native-background-upload#174)) ([d0ee16e](Vydia/react-native-background-upload@d0ee16e))
This PR adds a very basic app setup for testing this repository. To make this app work, I had to disable the automatic dependency linking. Server-side I've created a simple express.js server, that has to be started separately, see README.
The Android tests do not fully work, but iOS work fine for me.
The App has two buttons that do calls against a server (upload with response 200 and 502). This could be extended in the future.