upload more than 2 videos at the same time #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BaderSerhan Thanks for submitting! @L-Yeiser please loop back if you able to test this successfully |
|
Thank's! |
|
Will start testing it today. Thanks! |
StevePotter
approved these changes
Apr 8, 2019
|
Tested this in our staging environment and it works as expected. Unfortunately due to other issues around complete / error events not firing we cannot implement full testing in production. |
|
any ETA on this getting merged? |
|
@dcurletti it's merged and published, thanks for the bump. https://github.com/Vydia/react-native-background-upload/releases/tag/v5.1.0 |
|
Glad could help, keep up the good work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that more than 2 videos can be uploaded concurrently. The previous behavior was that when we upload the 3rd video, "Lost connection to background services" error appears and all the videos get stuck (this is another issue, please have a look #134 ).
Check out the difference between uploadTask and uploadStreamedTask on Apple's documentation, Upload Task vs. Upload Streamed Task.
I based my fix on this suggestion found in
react-native-fetch-bloblibrary's issues.