fix cancelUpload not working #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSMMark
reviewed
Jan 2, 2019
| @@ -226,7 +226,8 @@ - (void)copyAssetToFile: (NSString *)assetUrl completionHandler: (void(^)(NSStri | |||
| RCT_EXPORT_METHOD(cancelUpload: (NSString *)cancelUploadId resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject) { | |||
| [_urlSession getTasksWithCompletionHandler:^(NSArray *dataTasks, NSArray *uploadTasks, NSArray *downloadTasks) { | |||
| for (NSURLSessionTask *uploadTask in uploadTasks) { | |||
| if (uploadTask.taskDescription == cancelUploadId) { | |||
| if ([uploadTask.taskDescription isEqualToString:cancelUploadId]){ | |||
| // == checks if references are equal, while isEqualToString checks the string value | |||
There was a problem hiding this comment.
Is this == comparison also an issue?
react-native-background-upload/ios/VydiaRNFileUploader.m
Lines 307 to 312 in ddbe25b
There was a problem hiding this comment.
It doesn't seem like an issue to me, it is entering the if condition correctly.
|
When will this be published to npm? Every time I |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancelling an upload is never working, due to the obj-C
ifcondition which was comparing references, instead of strings.