Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Test App and E2E tests #174

Merged
merged 14 commits into from
Mar 22, 2020
Merged

Adding Test App and E2E tests #174

merged 14 commits into from
Mar 22, 2020

Conversation

reime005
Copy link
Collaborator

This PR adds a very basic app setup for testing this repository. To make this app work, I had to disable the automatic dependency linking. Server-side I've created a simple express.js server, that has to be started separately, see README.

The Android tests do not fully work, but iOS work fine for me.

The App has two buttons that do calls against a server (upload with response 200 and 502). This could be extended in the future.

@TSMMark
Copy link
Contributor

TSMMark commented Oct 17, 2019

Thanks @reime005 please consider merging with https://github.com/Vydia/ReactNativeBackgroundUploadExample or update readme if not obvious enough in the readme to know it exists https://github.com/Vydia/react-native-background-upload#faqs

@reime005
Copy link
Collaborator Author

@TSMMark Oh, I haven't seen that. Should have read the readme more I guess. But anyway, don't you think that tests should be included in the main repository, so that you don't have to use a separate codebase just for testing?

@TSMMark
Copy link
Contributor

TSMMark commented Oct 18, 2019

I didn't see any tests in this PR but I could have missed them? Or you mean just having an app to test with manually?

I'd be happy to merge an example app with this repo, certainly. If you get a chance check out the existing example app and see if your test app is missing any features that exist already

@reime005
Copy link
Collaborator Author

This file: TestApp/e2e/upload.e2e.js includes some very simple tests. I will merge the example app into this branch

@reime005 reime005 force-pushed the detox-tests branch 4 times, most recently from 1a2e20c to 0f27ac8 Compare November 17, 2019 12:30
@reime005 reime005 force-pushed the detox-tests branch 3 times, most recently from 8a63805 to d324a5a Compare January 3, 2020 14:20
@reime005
Copy link
Collaborator Author

reime005 commented Jan 3, 2020

@TSMMark I've merged the example app into this repo, added E2E tests for both platforms and added Github Actions CI/CD with semantic-release. Would be great if you could check it out and configure the NPM_TOKEN (Settings -> Secrets) as well as enable Github branch-protection to require successful checks for a pull request

@reime005 reime005 requested a review from TSMMark January 24, 2020 10:20
@reime005 reime005 force-pushed the detox-tests branch 7 times, most recently from 691b5b0 to cd7eb77 Compare March 20, 2020 22:42
@reime005 reime005 force-pushed the detox-tests branch 10 times, most recently from 36ffc50 to 8181cf0 Compare March 21, 2020 16:14
@reime005 reime005 merged commit d0ee16e into Vydia:master Mar 22, 2020
github-actions bot pushed a commit that referenced this pull request Mar 22, 2020
# [5.2.0](v5.1.0...v5.2.0) (2020-03-22)

### Features

* adding e2e tests, build automation and linting  ([#174](#174)) ([d0ee16e](d0ee16e))
@github-actions
Copy link

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

benjamin777dev added a commit to benjamin777dev/react-native-upload that referenced this pull request Jun 10, 2024
# [5.2.0](Vydia/react-native-background-upload@v5.1.0...v5.2.0) (2020-03-22)

### Features

* adding e2e tests, build automation and linting  ([#174](Vydia/react-native-background-upload#174)) ([d0ee16e](Vydia/react-native-background-upload@d0ee16e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants