-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added sitemap #87
added sitemap #87
Conversation
siteUrl: 'https://vulcan.next', | ||
generateRobotsTxt: true, | ||
//outDir: './out/', for static builds | ||
exclude: ['/vns/*', '/login', '/profile', '/signup', '/admin', '/auth'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead have a whitelist approach with include
? Vulcan app are often private app so it make more sense to whitelist what you want to see in the sitemap than what you don't want to see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like that package supports include at the moment. However, I can change the robots disallow to allow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The robots.txt file I'm thinking of is something like?
allow: ['/','/docs/*'],
@@ -0,0 +1,11 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is in the postbuild command, you might want to add this file to .gitignore
@@ -0,0 +1,14 @@ | |||
# * | |||
User-agent: * | |||
Disallow: /vns/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it also autogenerated? It could also be in .gitignore
Great stuff thank you! Would you mind adding a word about this feature in the documentation? The file is there: I try to keep track of all features we add progressively |
Sounds good to me thanks for the quick update and the work! |
No problem, should I write a test for this? |
that could help indeed, you could add a test in "/tests/vns", for example inspired from "packages.test.ts". You could run the relevant |
This adds a sitemap and robots file in
postbuild
with next-sitemap.