refactor: [automl/epsilon_decay] integrate robust confidence sequences #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalo
reviewed
Dec 20, 2022
| 0.333333 0.491667 4 4.0 1:1:1 0:0.97 23278 | ||
| 0.293750 0.254167 8 8.0 0:1:1 2:0.97 13862 | ||
| 0.273958 0.254167 16 16.0 0:1:1 2:0.97 2249 | ||
| -0.33333 -0.33333 1 1.0 0:-1:1 0:0.33 8436 |
There was a problem hiding this comment.
why would loss change on the first example if the CS is not used for loss?
There was a problem hiding this comment.
I had to change the rewards because the new estimator can only use rewards between 0 and 1, implying a costs between -1 and 0
lalo
approved these changes
Dec 22, 2022
jackgerrits
requested changes
Dec 23, 2022
| @@ -4,11 +4,9 @@ | |||
|
|
|||
| #pragma once | |||
There was a problem hiding this comment.
Simulator should definitely not be a part of the core lib. It's only used for test code and so should be in either the core tests or test_common.
jackgerrits
requested changes
Dec 23, 2022
jackgerrits
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.