refactor: allow reduction to control print frequency #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalo
approved these changes
Dec 6, 2022
lalo
reviewed
Dec 6, 2022
| @@ -580,7 +580,10 @@ void output_example_prediction_ccb( | |||
| void print_update_ccb(VW::workspace& all, shared_data& /* sd */, const ccb_data& data, const VW::multi_ex& ec_seq, | |||
| VW::io::logger& /* unused */) | |||
| { | |||
| if (!ec_seq.empty() && !data.no_pred) | |||
| const bool should_print_driver_update = | |||
There was a problem hiding this comment.
maybe throw this in SD as a default print update cadence
There was a problem hiding this comment.
Discussed offline, will address later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone back and forth on this one, but because of things like search and audit_regressor I think we need to leave the control with the reduction to decide if it wants to print an update.