Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove regex from clang-tidy-diff command as it wasnt working #4294

Merged
merged 2 commits into from
Dec 1, 2022
Merged

build: remove regex from clang-tidy-diff command as it wasnt working #4294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ea5d30
build: remove regex from clang-tidy-diff command as it wasnt working
jackgerrits Nov 30, 2022
d72784f
Update flake.nix
jackgerrits Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
flake-utils.lib.eachDefaultSystem (system:
let pkgs = nixpkgs.legacyPackages.${system}; in
let
# Note: this compile_commands.json does not work with clangd because it
# uses the nix clang-wrapper which abstracts enough away so that clangd
# can no longer find the right includes.
generate-compile-commands = ''
echo -n "Generating compile_commands.json... "
rm -rf $TMPDIR/compile_commands_build
Expand Down Expand Up @@ -92,7 +95,7 @@
let
clang-tidy-diff-script = pkgs.writeShellScriptBin "vw-clang-tidy-diff" ''
${generate-compile-commands}
${python-clang-tidy-package}/bin/clang-tidy-diff -p1 -path $TMPDIR/compile_commands_build -r '^.*\.(cc|h)\$' -quiet -use-color "$@" <&0
${python-clang-tidy-package}/bin/clang-tidy-diff -p1 -path $TMPDIR/compile_commands_build -quiet -use-color "$@" <&0
'';
in
{
Expand Down