-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Use nix to manage dev tooling starting with clang-tidy #4292
Merged
jackgerrits
merged 18 commits into
VowpalWabbit:master
from
jackgerrits:clang-tooling-nix
Nov 29, 2022
Merged
build: Use nix to manage dev tooling starting with clang-tidy #4292
jackgerrits
merged 18 commits into
VowpalWabbit:master
from
jackgerrits:clang-tooling-nix
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
approved these changes
Nov 28, 2022
lalo
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nix allows us to have a consistent developer environment. Perhaps the most useful instance of this is that the commands that are run locally use the exact same version of tooling as what is run in CI.
Documentation:
All args are passed through to the underlying
run-clang-format
call.To run clang-tidy on all files, as is done in CI you can run:
To just check specific files you can pass them as args:
To apply fixes use
-fix
:Using from Windows:
docker run -v %cd%:/src -it nixos/nix nix --extra-experimental-features nix-command --extra-experimental-features flakes develop /src -c vw-clang-tidy