Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clang-tidy only errors #4129

Merged
merged 10 commits into from
Aug 25, 2022
Merged

ci: clang-tidy only errors #4129

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7be3b22
ci: clang-tidy only errors
lalo Aug 25, 2022
a9705a2
test with quiet
lalo Aug 25, 2022
ca2821a
Update run-clang-tidy.sh
lalo Aug 25, 2022
15c18ed
Update run-clang-tidy.sh
lalo Aug 25, 2022
7411755
Update run-clang-tidy.sh
lalo Aug 25, 2022
5e725a6
Update run-clang-tidy.sh
lalo Aug 25, 2022
39bbd8c
Update run-clang-tidy.sh
lalo Aug 25, 2022
d8916bf
Update run-clang-tidy.sh
lalo Aug 25, 2022
42b2317
Update run-clang-tidy.sh
lalo Aug 25, 2022
c4f39ba
Update run-clang-tidy.sh
lalo Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .scripts/linux/run-clang-tidy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,13 @@ cd $REPO_DIR

# -DCMAKE_EXPORT_COMPILE_COMMANDS=On is manually set because in CMake 3.16, just setting it in the CMakeLists.txt does not work.
cmake -S . -B build -DFMT_SYS_DEP=On -DSPDLOG_SYS_DEP=On -DVW_BOOST_MATH_SYS_DEP=On -DBUILD_TESTING=Off -DVW_BUILD_VW_C_WRAPPER=Off -DCMAKE_EXPORT_COMPILE_COMMANDS=On
run-clang-tidy -p build -header-filter=vw/*
run-clang-tidy -p build -quiet -header-filter=vw/* 1>tidy_out.txt 2>tidy_error.txt || true
grep -A 3 ": error" tidy_out.txt > tidy_onlyerrors.txt

if [ -s tidy_onlyerrors.txt ]; then
# file has contents
cat tidy_onlyerrors.txt
exit 11
else
cat tidy_out.txt
fi