Skip to content

Commit

Permalink
build: remove regex from clang-tidy-diff command as it wasnt working
Browse files Browse the repository at this point in the history
  • Loading branch information
jackgerrits authored Nov 30, 2022
1 parent a295b6e commit 5ea5d30
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
let
clang-tidy-diff-script = pkgs.writeShellScriptBin "vw-clang-tidy-diff" ''
${generate-compile-commands}
${python-clang-tidy-package}/bin/clang-tidy-diff -p1 -path $TMPDIR/compile_commands_build -r '^.*\.(cc|h)\$' -quiet -use-color "$@" <&0
${python-clang-tidy-package}/bin/clang-tidy-diff -p1 -path $TMPDIR/compile_commands_build -quiet -use-color "$@" <&0
'';
in
{
Expand Down

1 comment on commit 5ea5d30

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 5ea5d30 Previous: a295b6e Ratio
BenchmarkLearnSimple.Benchmark(args: 1_feature) 5972.916666666667 ns (± 211.1161657973944) 725.3560879651238 ns (± 14.39846782048047) 8.23

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.