Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double-free issue in into_owner method #25

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fix double-free issue in into_owner method #25

merged 1 commit into from
Oct 5, 2021

Conversation

steffahn
Copy link
Contributor

@steffahn steffahn commented Oct 5, 2021

Closes #24

@steffahn steffahn mentioned this pull request Oct 5, 2021
Closed
@steffahn
Copy link
Contributor Author

steffahn commented Oct 5, 2021

FFS, a merge conflict. Ah, probably on the import? …

@steffahn
Copy link
Contributor Author

steffahn commented Oct 5, 2021

Rebased.

@Voultapher
Copy link
Owner

Looks good, going to push minor style changes.

@steffahn
Copy link
Contributor Author

steffahn commented Oct 5, 2021

FYI, the way the into_owner_without_panic name is to differentiate from a into_owner_with_panic that I’d like to add later for testing the leak-prevention in a later PR.

@Voultapher Voultapher force-pushed the fix_double_free branch 2 times, most recently from 183a99b to 1a0dd14 Compare October 5, 2021 16:19
@Voultapher Voultapher merged commit 684e6ad into Voultapher:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double-free with into_owner
2 participants
@steffahn @Voultapher