Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align product modal styles with regular buy button styles #5

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

PeeterPaal
Copy link
Collaborator

Make product modal use similar styles as regular buy button, with some additional fixes to smooth over any differences between them.

Closes #4

Testing:
Add a product widget to your page and make sure Show product modal on click option is active. Open up product modal in previewmode and make sure that all styles are similar to design's regular styles. Main color and button styles should also apply in product modal.

To make sure that custom styles are preferred to default styles, import
them as the last module.
As product modal is not inside of formatted content, bring button styles
out of formatted content styles.
Make buy button styles work with regular buy button & product modal.
In addition, fix a few other visual differences between regular
buybutton and modal's button.
@PeeterPaal PeeterPaal added the enhancement New feature or request label Jan 11, 2024
@PeeterPaal PeeterPaal self-assigned this Jan 11, 2024
Copy link
Member

@tanelj tanelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@PeeterPaal PeeterPaal merged commit 17d8d2d into main Jan 11, 2024
@PeeterPaal PeeterPaal deleted the 4-product-modal-styles branch January 11, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align product modal styles with buy button styles
2 participants