Remove threshold from IntersectionObserver
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As content inserted to Common Page may be longer, it can be possible that 70% of content will never be visible at once, and thus content will never be visible. Remove threshold to mitigate this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As content inserted to Common Page may be longer, it can be possible that 70% of content will never be visible at once, and thus content will never be visible. Remove threshold to mitigate this issue.
Closes #2
Testing:
Create a new page with Common page layout and insert a long text into one content area. Make sure that inserted content becomes visible in previewmode.