Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small bits from reviewing numbers API #498

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Aug 20, 2024

This PR contains minor housekeeping for the Numbers Client.

Description

One of the main things included is removing frivolous docblocks, as the hardened type system means docblocks have only been left alone if they have context. Most @params for instance have been removed.

Motivation and Context

Scout rule to add minor improvements.

How Has This Been Tested?

Modified some tests to make sure the URL string is being stitched together correctly.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SecondeJK SecondeJK merged commit 1167fa4 into main Aug 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant