feat: proactive connect #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #818 +/- ##
==========================================
+ Coverage 78.94% 79.01% +0.06%
==========================================
Files 104 89 -15
Lines 1211 1215 +4
Branches 234 239 +5
==========================================
+ Hits 956 960 +4
Misses 255 255
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
manchuck
force-pushed
the
proactive-connect
branch
from
423546d to
1c3f294
Compare
manchuck
force-pushed
the
proactive-connect
branch
from
1c3f294 to
82ad1a3
Compare
dragonmantank
requested changes
Apr 25, 2023
| file: string, | ||
| ): Promise<ImportFileResponse> { | ||
| const itemsForm = new FormData(); | ||
| itemsForm.setBoundary(this.FORM_BOUNDARY); |
There was a problem hiding this comment.
Is there not a library that can handle creating multipart form bodies?
There was a problem hiding this comment.
This lib does, but it creates a different form on each instance. We set the form boundary here for testing purposes. I went through several libs to parse multi-parts, and they were all crap except for the one we are using. However that one needs the boundary explicitly set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in proactive connect
Description
Motivation and Context
Testing Details
Example Output or Screenshots (if appropriate)
Types of changes
Checklist