Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kebabecase api parameters #802

Merged
merged 1 commit into from
Mar 8, 2023
Merged

fix: kebabecase api parameters #802

merged 1 commit into from
Mar 8, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Mar 3, 2023 •
edited
Loading

Fixing sending kebab case for SMS request body

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck force-pushed the fix-sms-client-ref branch 2 times, most recently from 9ade5f6 to dae0fec Compare March 3, 2023 20:29
@manchuck manchuck marked this pull request as ready for review March 3, 2023 20:30
@manchuck manchuck requested a review from dragonmantank March 3, 2023 20:30
@manchuck manchuck force-pushed the fix-sms-client-ref branch from dae0fec to ea66d2a Compare March 7, 2023 19:05
dragonmantank
dragonmantank approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manchuck manchuck merged commit c71d424 into 3.x Mar 8, 2023
@manchuck manchuck deleted the fix-sms-client-ref branch March 8, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmantank dragonmantank dragonmantank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manchuck @dragonmantank