Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: redact module #798

Merged
merged 1 commit into from
Mar 8, 2023
Merged

feat: redact module #798

merged 1 commit into from
Mar 8, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Feb 27, 2023 •
edited
Loading

Provides SDK access for the redact API

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck marked this pull request as ready for review February 27, 2023 21:10
@manchuck manchuck removed request for conshus and abdulajet March 1, 2023 18:00
dragonmantank
dragonmantank requested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull out audit, and some minor text changes

README.md Outdated Show resolved Hide resolved
packages/redact/lib/interfaces/response/errorResponse.ts Show resolved Hide resolved
packages/server-sdk/README.md Outdated Show resolved Hide resolved
packages/server-sdk/lib/vonage.ts Outdated Show resolved Hide resolved
@manchuck manchuck requested a review from dragonmantank March 3, 2023 20:25
@manchuck manchuck force-pushed the redact-module branch 2 times, most recently from a94f7b6 to ccf9ff7 Compare March 7, 2023 19:04
dragonmantank
dragonmantank approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisionally approving depending on if we need to fix the versions in the server-sdk package.json

packages/server-sdk/package.json
@@ -27,18 +27,18 @@
"compile": "npx tsc --build --verbose"
},
"dependencies": {
"@vonage/accounts": "^1.1.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to rebase here? We've ended up dropping back on all these packages.

If this is going to get cleaned up before deploy we can ignore this for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, once this and the SMS PR gets merged in, I will clean up the packages.

@manchuck manchuck merged commit 35868e7 into 3.x Mar 8, 2023
@manchuck manchuck deleted the redact-module branch March 8, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmantank dragonmantank dragonmantank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manchuck @dragonmantank