fix: allow no filter when getting owned numbers, require filter when searching available numbers #747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed it so a user can pass in an empty filter when getting their owned numbers
Changed it so that a user is forced to pass in a filter when searching for available numbers, as a country is always required for that API call
Motivation and Context
Bug found when building out a demo app. While you can pass in an empty filter for getting owned numbers, it's more intuitive to allow the user to just not specify one at all.
When checking the above, came across that we allowed an optional filter on the getting available numbers call. You always have to at least pass in a country, so this enforces that rule as the user would have to pass in one to get a valid result anyway.
Testing Details
Unit tests
Example Output or Screenshots (if appropriate)
Types of changes
Checklist