Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow no filter when getting owned numbers, require filter when searching available numbers #747

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

dragonmantank
Copy link
Contributor

Description

Changed it so a user can pass in an empty filter when getting their owned numbers
Changed it so that a user is forced to pass in a filter when searching for available numbers, as a country is always required for that API call

Motivation and Context

Bug found when building out a demo app. While you can pass in an empty filter for getting owned numbers, it's more intuitive to allow the user to just not specify one at all.

When checking the above, came across that we allowed an optional filter on the getting available numbers call. You always have to at least pass in a country, so this enforces that rule as the user would have to pass in one to get a valid result anyway.

Testing Details

Unit tests

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dragonmantank dragonmantank merged commit ac80247 into 3.x Nov 30, 2022
@dragonmantank dragonmantank deleted the fix-allow-empty-filter-on-owned-numbers branch November 30, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants