-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(components): enforce extensions to align with esm #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into type-module-support # Conflicts: # libs/components/package.json
# Conflicts: # libs/components/jest.config.cjs # libs/components/project.json
… into type-module-support
yinonov
changed the title
Enforce-extensions
style(components): enforce extensions to align with esm
May 1, 2022
yinonov
added
the
Type: Style ⭐
changes that do not affect the meaning of the code
label
May 8, 2022
yinonov
commented
May 9, 2022
waiting on rollup/plugins#1058 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see reason why barrel file does not satisfy extension rule
import-js/eslint-plugin-import#1920 (comment)
------- edit
removing eslint import/extensions rule in favor of typescript moduleResolution "nodeNext"
see
microsoft/TypeScript#42813 (comment)