Skip to content

Check if key is defined befory loading the entity, fix array_flip warning #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 8.x-1.x
Choose a base branch
from
+17 −14
Open

Check if key is defined befory loading the entity, fix array_flip warning #2

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42059ff
Check if key is defined befory loading the entity, fix array_flip war…
idflood Jun 29, 2018
e09928a
Move key condition above
idflood Jul 18, 2018
d0b865f
Compatibility with drupal 9
idflood Oct 20, 2021
95af77a
Merge branch '8.x-1.x' into fix-array-flip-warning
idflood Oct 20, 2021
b6dd618
Drupal 10 compatibility
idflood Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Plugin/views/filter/Selective.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,10 +457,12 @@ protected function getOids() {
$value = NULL;

if (NULL !== $entityTypeStorage) {
Copy link

@joelpittet joelpittet Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add the $key empty check to the condition above?

$entity = $entityTypeStorage->load($key);
if ($key) {
$entity = $entityTypeStorage->load($key);

if ($entity) {
$value = $entity->label();
if ($entity) {
$value = $entity->label();
}
}
}
else {
Expand Down