Skip to content
This repository was archived by the owner on Apr 2, 2022. It is now read-only.

Action now accounts for updateComment data structure.#27

Open
fiatjaf wants to merge 1 commit intomasterfrom
unknown repository
Open

Action now accounts for updateComment data structure.#27
fiatjaf wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@fiatjaf
Copy link
Contributor

@fiatjaf fiatjaf commented Feb 27, 2016

This is needed for actions with type updateComment.

@fiatjaf
Copy link
Contributor Author

fiatjaf commented Feb 27, 2016

I understand all structs in this library were written with the JSON returned by Trello with the default parameters (for example, when fetching /1/cards/<id> without passing any querystring parameter), but since passing arbitrary arguments will now be supported (the plan is to make #14 work for all methods, right?) we will need to make the structs support all kinds of possible data that may come in the responses, correct?

(This PR doesn't address this, it is just a small fix for Action)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant