Google provider December removal#145
Closed
olegkachur-e wants to merge 2 commits into
Closed
Conversation
moiseenkov
suggested changes
Dec 19, 2024
moiseenkov
left a comment
There was a problem hiding this comment.
Well done!
There are only two things I'd kindly ask you to amend:
- please add an announcement about breaking changes and the major version bump in the
providers/src/airflow/providers/google/CHANGELOG.rstthe same way it has been done last time. - please rename unit test classes, so the old operators' names were vanished from everywhere and the current tests had consistent names:
TestCreateDataPipelineOperator->TestDataflowCreatePipelineOperator
TestRunDataPipelineOperator->TestDataflowRunPipelineOperator
MaksYermak
approved these changes
Dec 19, 2024
a3e3aee to
91f5644
Compare
Collaborator
Author
Brilliant mentions, thank you! |
Thank you! All is good, but please move changelog announcements into a new section for the new 12.0.0 version. |
91f5644 to
37c47e8
Compare
moiseenkov
reviewed
Dec 19, 2024
37c47e8 to
dfb7096
Compare
moiseenkov
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.